-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of #735 to secp256k1-sys 0.10 #736
Backport of #735 to secp256k1-sys 0.10 #736
Conversation
Do we want to ignore CI? |
Yes. We only just started making an effort to fix CI to pin tooling last week. We don't want to try to backport all those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK bb026c4
bb026c4
to
21f67d5
Compare
Forgot to update the lockfiles (which in 0.29.x exist but are not checked in CI). Will get my local CI working on this before merging.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully ran local tests on 21f67d5.
Note to self: needed to add
to my local CI script to get it to pass, since by default it wants the symbols in secp-sys to match the version in Cargo.toml exactly. (But doing this would turn a non-breaking change into a breaking one, which is why I didn't.) |
@apoelstra your CI fail made me realize we should do the same thing here as we do in |
What in particular? |
Version the API, not the library and put the upstream version into metadata instead. |
Agreed. Though for purposes of this PR, we can't make such a change (as it'd be a breaking change to change our version format at all). |
Well, we already are breaking our format here, but obviously I'm not NACKing this. |
Will you ACK it? :} Fine if you don't want to, but there aren't a lot of maintainers on this repo and you're the one who appears to be active right now. |
I already did and since GH didn't dismiss my review I haven't noticed the force push. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 21f67d5
Tagged and published. |
This backports #735. I am PR'ing to the secp256k1-0.29.x branch because this will work and because it feels like unnecessary complication to try to create a secp256k1-sys-0.10.x branch, which might be "more correct" but would make our git tree harder to understand and maintain.
As in #735, this just deletes some dead code from secp256k1-sys/depend/secp256k1.